-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hpa stats for current utilization and average value #961
Conversation
Welcome @ashleykasim! |
fc0b0da
to
564a2dc
Compare
059157c
to
f16bd59
Compare
/assign @lilic |
Thanks for your PR @ashleykasim. I've provided my comments. Will wait on @lilic for her comments as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, after those are addressed and @tariq1890 ones, this is good to go. Thanks for the PR!
f16bd59
to
ca01c1a
Compare
ca01c1a
to
8f01454
Compare
8f01454
to
0884484
Compare
@ashleykasim is this ready for another review? |
@lilic Yes please! |
47f58c8
to
e7aaca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you for your contribution @ashleykasim :).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashleykasim, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the contribution! 🎉 |
What this PR does / why we need it:
When debugging issues such as kubernetes/kubernetes#82195, it was necessary to export these stats in order to understand what the hpa sees at the time of the overflow and other such bugs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #